Skip to content

Jenkins report set up synchronization and CheckStyle rules discussion - part1

Meeting Info

Date 2022-10-13
Topic Jenkins report set up synchronization and CheckStyle rules discussion - part1
Attendee Rocky Chi, Daniel Zhou, Ted Zhao, Jackson Liu, Kevin Qian
Note Taker Daniel Zhou
Timer Kevin Chen
Duration 40 minutes

Meeting Agenda

  1. Sync Jenkins report set up status (if capable) - 10 mins

  2. Discuss on CheckStyle rules part1 - 30 mins

Meeting Minutes

1. Sync Jenkins report set up status

We reviewed MCT some reports and checked if we need to do some changes. We will need to add one more CheckStyle rules according to today's meeting discussion.

2. CheckStyle Rules Discussion

We had a review and learning for CheckStyle Rules firstly, then had a discussion for below rules. 

<module name="ArrayTrailingComma">
    <property name="severity" value="warning"/> <!-- recommand -->
    <property name="alwaysDemandTrailingComma" value="false"/>
</module>
<module name="AvoidDoubleBraceInitialization">
    <property name="severity" value="error"/> <!-- mandatory -->
</module>
<module name="AvoidInlineConditionals">
    <property name="severity" value="info"/> <!-- reference -->
</module>
<module name="AvoidNoArgumentSuperConstructorCall">
    <property name="severity" value="warning"/> <!-- recommand -->
</module>
<module name="CovariantEquals">
    <property name="severity" value="error"/> <!-- mandatory -->
</module>
<module name="DeclarationOrder">
    <property name="severity" value="warning"/> <!-- recommand -->
    <property name="ignoreConstructors" value="false"/>
    <property name="ignoreModifiers" value="false"/>
</module>
<module name="DefaultComesLast">
    <property name="severity" value="error"/> <!-- mandatory -->
    <property name="skipIfLastAndSharedWithCase" value="true"/>
</module>
<module name="EmptyStatement">
    <property name="severity" value="error"/> <!-- mandatory -->
</module>
<module name="EqualsAvoidNull">
    <property name="severity" value="error"/> <!-- mandatory -->
    <property name="ignoreEqualsIgnoreCase" value="false"/>
</module>
<module name="EqualsHashCode">
    <property name="severity" value="error"/> <!-- mandatory -->
</module>
<module name="ExplicitInitialization">
    <property name="severity" value="warning"/> <!-- recommand -->
    <property name="onlyObjectReferences" value="false"/>
</module>
<module name="FallThrough">
    <property name="severity" value="error"/> <!-- mandatory -->
    <property name="checkLastCaseGroup" value="true"/>
</module>

Action Items

  1. We need to research and schedule one report job which can send reports every Friday.
  2. Maybe we can integrate with teams bot, and it will be better if we can send to one teams room by a picture. If can't send by a picture, we can send by words.
  3. Ted needs to focus on Java plugin for CheckStyle as high priority. So that we can use the plugin in projects and don't keep CheckStyle xml in project one by one.