Skip to content

Checkstyle Coding Rule part4

Meeting Info

Date 2022-12-08
Topic Checkstyle Coding Rule
Attendee Calvin Yan, Selly Huang, Rocky Chi, Daniel Zhou, Ted Zhao
Note Taker Daniel Zhou
Timer Rocky Chi
Duration 60 minutes

Meeting Agenda

  1. Go through Jenkins report.
  2. Go through Checkstyle coding rule part4.

Meeting Minutes

Checkstyle Rule - Coding part 4

<module name="OneStatementPerLine">
<property name="severity" value="warning"/>
<property name="treatTryResourcesAsStatement" value="true"/>
</module>
<module name="OverloadMethodsDeclarationOrder">
<property name="severity" value="warning"/>
</module>
<module name="PackageDeclaration">
<property name="severity" value="ignore"/>
</module>
<module name="ParameterAssignment">
<property name="severity" value="warning"/>
</module>
<module name="ReturnCount">
<property name="severity" value="reference"/>
</module>
<module name="SimplifyBooleanExpression">
<property name="severity" value="warning"/>
</module>
<module name="SimplifyBooleanReturn">
<property name="severity" value="warning"/>
</module>
<module name="StringLiteralEquality">
<property name="severity" value="error"/>
</module>
<module name="SuperClone">
<property name="severity" value="ignore"/>
</module>
<module name="SuperFinalize">
<property name="severity" value="ignore"/>
</module>
<module name="UnnecessaryParentheses">
<property name="severity" value="ignore"/>
</module>
<module name="UnnecessarySemicolonAfterOuterTypeDeclaration">
<property name="severity" value="ignore"/>
</module>
<module name="UnnecessarySemicolonAfterTypeMemberDeclaration">
<property name="severity" value="ignore"/>
</module>
<module name="UnnecessarySemicolonInEnumeration">
<property name="severity" value="ignore"/>
</module>
<module name="UnnecessarySemicolonInTryWithResources">
<property name="severity" value="ignore"/>
</module>
<module name="UnusedLocalVariable">
<property name="severity" value="warning"/>
</module>
<module name="VariableDeclarationUsageDistance">
<property name="severity" value="ignore"/>
</module>

Action Items

  1. Check why the schedule job doesn't work for all reports - Ted.
  2. Need to apply part2, part3 and part4 rules into each project - Ted & Daniel.

Next meeting topic

  1. Review Jenkins report.
  2. We need to think on how to improve the doc level in each project. To identify what are the critical documents in each project, and how good or bad it is now.